Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollback lunchbox of aqara fp2 #1655

Closed
wants to merge 1 commit into from
Closed

rollback lunchbox of aqara fp2 #1655

wants to merge 1 commit into from

Conversation

hdlee27
Copy link
Contributor

@hdlee27 hdlee27 commented Sep 30, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions GitHub Actions
Copy link

Test Results

   63 files    395 suites   0s ⏱️
1 932 tests 1 932 ✅ 0 💤 0 ❌
3 356 runs  3 356 ✅ 0 💤 0 ❌

Results for commit 8ecfeb3.

@github-actions GitHub Actions
Copy link

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 8ecfeb3

@ldeora
Copy link

ldeora commented Sep 30, 2024 •
edited
Loading

Thanks for creating the PR!

We should test it in beta first or even better in the original PR:

#1546

But I hope that this will fix the root problem:

#1654

@lelandblue lelandblue requested a review from FreeMasen October 1, 2024 18:18
@lelandblue
Copy link
Contributor

Hello @hdlee27 If I am not mistaken, I believe we can close this PR. Is that ok?

@hdlee27
Copy link
Contributor Author

hdlee27 commented Oct 14, 2024

I apologize for the late response. this PR is no longer needed, thanks to your quick response. I really appreciate it.

@hdlee27 hdlee27 closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreeMasen FreeMasen Awaiting requested review from FreeMasen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdlee27 @ldeora @lelandblue